Add Footer#9
Open
norioriroiron wants to merge 3 commits into
Open
Conversation
Open
7 tasks
AJaccP
requested changes
Jun 6, 2026
| return ( | ||
| <footer className="bg-black border-t-red-600 border-t-2 p-1"> | ||
| <p className="text-center text-white text-xs"> | ||
| <b>Carleton Computer Science Society</b> |
Contributor
There was a problem hiding this comment.
Forgot to include this in the original ticket but it would be good to have this text link to our main website:
https://ccss.carleton.ca/.
| @@ -0,0 +1,20 @@ | |||
|
|
|||
| export default function Footer() { | |||
Contributor
There was a problem hiding this comment.
Content's all here which is great! A couple notes, mostly visual and about text hierarchy:
- "Carleton Computer Science Society" at the start should be the most prominent part, so you can make the text bigger / bolder. Try using something like Tailwinds'
text-lg font-semiboldwhile the rest staystext-xs. - The copyright line at the end can also be slightly bigger than the disclaimer lines. Try using
text-smfor that instead oftext-xs) - Looking at the single column, it looks a bit tall. It might be worth making the GitHub repo link inline with one of the other lines, maybe the copyright one? So it looks like (© 2026 Carleton Computer Science Society · GitHub).
- For consistency, use Tailwind + block elements instead of raw
<b>, <u> or <br/>tags.<b>→ font-bold (or font-semibold)<u>→ underline- the
<br/>s → wrap each line in its own<p> or <div>and let spacing handle the breaks, rather than manual line breaks
| <br/> | ||
| Not affiliated with or endorsed by Carleton University. | ||
| <br/> | ||
| Always verify course requirements in the official undergraduate calendar. |
Contributor
There was a problem hiding this comment.
Would be good to have the "official undergraduate calendar" text link to:
https://calendar.carleton.ca/undergrad/undergradprograms/computerscience/
| import Header from '@/components/Header'; | ||
| import Explorer from '@/pages/Explorer'; | ||
| import Planner from '@/pages/Planner'; | ||
| import Footer from '@/components/Footer' |
Contributor
There was a problem hiding this comment.
Minor: missing semicolon. Run pnpm format before committing, it should fix errors like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.